Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented tests and fixed default timeout value to not soo huge #435

Conversation

dbalabka
Copy link
Contributor

It fixes wrong huge default value for timeout that was introduced in #429

  • be sure that Travis tests works fine

IMPORTANT! To prepare ssh tests, I have to use sudo: required that means that all tests will run on old Travis infrastructure not container-base

@dbalabka dbalabka force-pushed the timeout-problem-fix-and-tests-implementation branch 7 times, most recently from 99555a7 to f1d867b Compare August 20, 2015 22:15
@oanhnn
Copy link
Contributor

oanhnn commented Aug 21, 2015

Sorry @torinaki ,
This is an important issue, it introduces error in version 3.0.7 and 3.0.8.
I want to merge this PR without adding tests (all tests will be reviewed by @Elfet or other maintainer).
Please split this PR to two PR:

  • fixed default timeout value
  • adding tests
    Thank you!

@antonmedv
Copy link
Member

Thanks for fix! 🍻
I think @oanhnn is right, but now we need to fix it as soon as possible.
So i merge this PR.
@torinaki is it possible to implement this tests, but on new travis dockers?

antonmedv pushed a commit that referenced this pull request Aug 21, 2015
…mplementation

Implemented tests and fixed default timeout value to not soo huge
@antonmedv antonmedv merged commit 4a67557 into deployphp:master Aug 21, 2015
@antonmedv antonmedv mentioned this pull request Aug 21, 2015
@dbalabka
Copy link
Contributor Author

@Elfet , @oanhnn here is PR #438 . Manually tested both cases(w/o bug, with bug)

@dbalabka
Copy link
Contributor Author

@Elfet about tests implementation on new travis docker. I was searching on github for already existing examples, but unfortunatly no luck. My current implementation was based on phpseclib implementation.
Currenlty i have few ideas where we should drip. One of them the most real is:
Try to install SSH server on travis docker. It should listen on 127.0.0.1(it is possible). For example we can try to install binary of openssh server: https://help.ubuntu.com/lts/serverguide/openssh-server.html .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants