Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fixes problem with command execution timeout #429

Merged
merged 1 commit into from
Aug 16, 2015

Conversation

dbalabka
Copy link
Contributor

It temporary fixes problem that described in phpseclib/phpseclib#775.
For example composer install may be stoped on the middle of progress if it takes more than 10 sec.

@antonmedv
Copy link
Member

Cool! Thanks!

antonmedv pushed a commit that referenced this pull request Aug 16, 2015
Temporary fixes problem with command execution timeout
@antonmedv antonmedv merged commit 42411c5 into deployphp:master Aug 16, 2015
@dbalabka
Copy link
Contributor Author

@Elfet @oanhnn it will be greate to prepare new release with this fix, because this may affect many users.
I'm sure that was itroduced by #428 after phpseclib update

@antonmedv
Copy link
Member

Ok! @deployphp/maintainer can anybody make new release?

@oanhnn
Copy link
Contributor

oanhnn commented Aug 20, 2015

I created a new release. @torinaki @AlexStansfield , Please test again!

@AlexStansfield
Copy link
Contributor

Sorry I get:

PHP Notice:  Cannot connect to stage.ourserver.com:22. Error 60. Operation timed out in phar:///Users/alex/Downloads/deployer (1).phar/vendor/phpseclib/phpseclib/phpseclib/Net/SSH2.php on line 1011

When it tries to connect.

Putting in a number like 3600 does work though. I suggest putting a setting that can be changed but defaults to something reasonable like 10 minutes. PHP_INT_MAX on my machine is 9223372036854775807 and it seems it really messes with it.

dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
dbalabka added a commit to dbalabka/deployer that referenced this pull request Aug 20, 2015
@dbalabka
Copy link
Contributor Author

@AlexStansfield , @Elfet , @oanhnn I was able to reproduce problem. Sorry guys it was my bad. Found that I was testing with patched phpseclib with few fixed issues by me.
Adding 3600 as default timeout is proper fix in this case. I have prepared PR #435 with fix and prepared functional tests that cover timeout case. Please check PR, because I have to change Travis configurations to achieve possibility to implement these tests. In case if you will not agree to change Travis changes I will remove tests from PR.

@dbalabka
Copy link
Contributor Author

The problem was as I said before was that fsockopen do not create socket with huge timeout, but 3600 is ok for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants