Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip overwriting existing service definition #4

Merged
merged 5 commits into from
Mar 18, 2016

Conversation

podhy
Copy link
Contributor

@podhy podhy commented Mar 17, 2016

Hello,
this PR disables overwriting of existing services definition and just sets autowire option to true.

This is very usefull when you want to pass e.g. scalar parametrs from parameters.yml into controller because in SF 2.8.3 you can do:

controller_service:
    class: SomeController
    arguments:
        - ''
        - %scalar_parametr%

And in upcomming SF 2.8.4:

controller_service:
    class: SomeController
    arguments:
        1: %scalar_parametr%

So the first parametr is autowired and the second is not

@TomasVotruba
Copy link
Member

Hi @podhy,

thanks for the improvement and adding tests. They really nicely cover the feature.

TomasVotruba pushed a commit that referenced this pull request Mar 18, 2016
Skip overwriting existing service definition
@TomasVotruba TomasVotruba merged commit 6227145 into deprecated-packages:master Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants