Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

[PHPStanRules] Duplicated methods get reported twice #2808

Closed
TomasVotruba opened this issue Jan 15, 2021 · 5 comments
Closed

[PHPStanRules] Duplicated methods get reported twice #2808

TomasVotruba opened this issue Jan 15, 2021 · 5 comments

Comments

@TomasVotruba
Copy link
Member

Right now, the error is reported twice for one pair. Just once is good enough.

image

Could you check it @samsonasik ?
@samsonasik
Copy link
Collaborator

I can't reproduce with latest rector master:

Screen Shot 2021-01-15 at 22 25 51

Could you give step to reproduce?

@TomasVotruba
Copy link
Member Author

The 2nd file has to be run too. The PSR4AUtoloadPathsProvider

@samsonasik
Copy link
Collaborator

samsonasik commented Jan 15, 2021 •
edited

is need to run in is-name branch at rectorphp/rector#5193 ? twice report probably related with autoloading somewhere, as it previously only reported once.

@TomasVotruba
Copy link
Member Author

Closing untill this appears again. I'll prove link to failing build and reproducible step so its possible to solve it

@TomasVotruba TomasVotruba reopened this Jan 16, 2021
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jan 16, 2021 •
edited

It's happening on Rector repository, e.g. https://github.com/rectorphp/rector/pull/5198/checks?check_run_id=1713527491#step:5:2686

It's this commit hash: rectorphp/rector@1e92985

samsonasik added a commit that referenced this issue Jan 16, 2021
@samsonasik
[PHPStanRules] Fixes #2808 Prevent duplicate display error message wh…
a935d69 
…en already reported for PreventDuplicateClassMethodRule
@deprecated-packages deprecated-packages locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samsonasik @TomasVotruba