This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
[Astral] copy over findFirst() and findFirstPrevious() from rector
#3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was lazy to write them, but test is needed for new methods. Even the old ones :) |
staabm
commented
Jan 8, 2022
| $this->bootKernel(AstralKernel::class); | ||
| $this->simpleNodeFinder = $this->getService(SimpleNodeFinder::class); | ||
|
|
||
| $phpParser = $this->getService(SmartPhpParser::class); |
There was a problem hiding this comment.
I am wondering why the SmartPhpParser does not use ParentConnectingVisitor and NodeConnectingVisitor .. is this intentional?
if so, is there another parser I could use in this test which is configured for the visitors?
staabm
changed the title
findFirst() and findFirstPrevious() from rector
This was referenced Jan 8, 2022
|
What is missing here to finish this PR? |
|
atm I don't need it, as I duplicated the logic into phpstan-dba. I will come to this back later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems these methods are not tested within astral.. so I just copied the methods over from rector
refs rectorphp/rector#6921