Published crate on Crates.io contains compilation artifacts

[djg]

We're trying to use this crate in gecko, but review was failed because this vendoring the published crate contains target/ folder. Is it possible to republish on crates.io with out target/?

[alexcrichton]

Hm what version are you using off crates.io? I just downloaded 0.6.0-0.6.4 and it looks like the target folder isn't present in any of them?

[djg]

That's odd. I'm specifying version 0.6.4 and seeing a target/ when running ./mach vendor rust in gecko.
For example, https://bugzilla.mozilla.org/attachment.cgi?id=8899315&action=diff#a/third_party/rust/mio-uds/.cargo-checksum.json_sec2 lists the files that I am seeing.

[alexcrichton]

Hm I wonder if that's a bug in cargo-vendor perhaps?

[djg]

Should I close this issue and open an issue with cargo-vendor? I'd like to diagnose the issue locally if that helps.

[alexcrichton]

Hm...

Can you find the mio-uds source code in $CARGO_HOME? Is there a target directory in there? If so do you know how that may have appeared?

[djg]

I have the following in ~/.cargo: ./.cargo/registry/src/github.com-1ecc6299db9ec823/mio-uds-0.6.4 ./.cargo/registry/src/github.com-1ecc6299db9ec823/mio-uds-0.6.4/target/debug/.fingerprint/mio-uds-7b2ccd05d532e5ac ./.cargo/registry/index/github.com-1ecc6299db9ec823/mi/o-/mio-uds ./.cargo/registry/cache/github.com-1ecc6299db9ec823/mio-uds-0.6.4.crate ./.cargo/.../cache/.../mio-uds-0.6.4.crate is .tar.gz has the correct code. ./.cargo/.../src/.../mio-uds-0.6.4/ contains a local build a target/ Is cargo-vendor picking up mio-uds from the src/ folder and vendoring that instead of using the files from crates.io (which I assume is in cache/) I'm not sure how mio-uds ended up in src. (I assume as the result of listing the code as a dep and building locally).

…

On 23 August 2017 at 13:40, Alex Crichton ***@***.***> wrote: Hm... Can you find the mio-uds source code in $CARGO_HOME? Is there a target directory in there? If so do you know how that may have appeared? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJhrWhPwX4JphEDwh3Pvyqg6pFHSrG5ks5sa58ZgaJpZM4O_WyW> .

-- Dan Glastonbury, Dan dot Glastonbury at gmail dot com `Pour encourjay lays ortras'

[alexcrichton]

Ah yeah currently cargo-vendor pulls from ~/.cargo/registry/src and just vendors everything in there (it assumes it hasn't been modified).

It seems odd that target is there though! Did you run cargo build locally in that dir?

[djg]

Not intentionally. Oh. I wonder if I used racer-find-definition to jump to the code when using UnixStream and accidentally modified the file causing my emacs check code for errors on save to kick in. That would leave a stray target folder without me realizing it. I checked with Matthew Gregan and he *doesn't* have a target folder inside of the src/ folder of his cargo registry. I'll close this issue as it's not an issue. thanks.

…

On 23 August 2017 at 14:18, Alex Crichton ***@***.***> wrote: Ah yeah currently cargo-vendor pulls from ~/.cargo/registry/src and just vendors everything in there (it assumes it hasn't been modified). It seems odd that target is there though! Did you run cargo build locally in that dir? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJhrfQoJxB2w5tu1FN_36I2aDBNJhSmks5sa6gYgaJpZM4O_WyW> .

-- Dan Glastonbury, Dan dot Glastonbury at gmail dot com `Pour encourjay lays ortras'

[alexcrichton]

Aha yes that may be it! Maybe file an issue with racer?

[djg]

It's a bug with flycheck-rust. I should exclude it from compiling inside the cargo registry.