fix: 회원탈퇴 데이터 삭제 방식 변경 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dbscks97
reviewed
Aug 29, 2024
| @Modifying | ||
| @Query( | ||
| "UPDATE MissionRecordBoost mrb SET mrb.deletedAt = CURRENT_TIMESTAMP WHERE mrb.member.id = :memberId") | ||
| @Query("DELETE FROM MissionRecordBoost mrb WHERE mrb.member.id = :memberId") |
There was a problem hiding this comment.
회의때에는 부스터 갯수는 남겨두기로 했던 거 같은데 이렇게하면 부스터도 같이 날아가지않나요?
There was a problem hiding this comment.
넵 맞아용 미션 기록이 지워졌는데 굳이 부스트를 DB에 남길 필요가 없다고 생각했어용
추후 마이그레이션을 진행한다고 가정했을때에도 불필요한 데이터라 생각했습니다
There was a problem hiding this comment.
음.. 그러면 피드에 뜨는 부스트갯수가 mission_record_boost에서가져오는 것 같은데 지우면 피드에 뜨는 숫자도 줄지않나요?
There was a problem hiding this comment.
아 내부적으로도 이야기 나왔었던 내용이네용
제가 놓쳤습니다..! 삭제 안되도록 수정할게요
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용
🙏 리뷰 요구사항
📚 레퍼런스