-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bottomSheet hooks 리팩토링 #286
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c651774
to
a456fdf
Compare
181a91f
to
3291620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~~👍🏻
hooks/useBottomSheet.ts
Outdated
}; | ||
|
||
const onClose = useCallback( | ||
(event?: MouseEvent<HTMLElement | HTMLButtonElement>) => { | ||
event && event.stopPropagation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stopPropagation을 넣으신 이유가 어떤 상황을 고려하신건가용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 잘못 넣었습니다.. 테스트하다가 넣었네요.. 제거했습니다!! 5d8830f
5d8830f
to
ef41122
Compare
Description
바텀시트 하위컴포넌트를 동적으로 변경하기 위해서 useBottomSheet 에 함수를 추가하였습니다.
Changes
useBottomSheet 를 사용하는 방법
페이지 1개에 bottomSheet 하위 컴포넌트가 고정일 때
페이지 1개에 bottomSheet children 이 변경될 수 있을 때
이점 (이라고 생각하는 부분)