review - bottom navigation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle SizesCompared against 3cc1d7d Route: No significant changes found Dynamic import: None found. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 39 39
Lines 244 244
Branches 41 41
=======================================
Hits 234 234
Misses 10 10 โ View full report in Codecov by Sentry. |
oyeon-kwon
reviewed
May 22, 2023
| export default meta; | ||
|
|
||
| export const Default = () => { | ||
| const [value, onChange, reset] = useInput(); |
There was a problem hiding this comment.
์ค useInput ํ ์ ์ด๋ ๊ฒ ์ธ์์๊ตฐ์ฉ
oyeon-kwon
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ค ํด๊ฒฐํ๋ ค๋ ๋ฌธ์ ๊ฐ ๋ฌด์์ธ๊ฐ์?
close #125
๐ ๋ณ๊ฒฝ ์ฌํญ
BottomNavigation์ปดํฌ๋ํธ๋ฅผ ๋ง๋ค์์ด์fixedBottomCss๋ฅผ ๋์ผํ๊ฒ ๊ฐ์ ธ์ ์ฌ์ฉํ๋ฉฐ ์ค๋ฒ๋ผ์ด๋ฉํด ์ฌ์ฉํด์๐ ์คํฌ๋ฆฐ์ท