Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepting wire payments #75

Closed
Tracked by #74
dallashuggins opened this issue Nov 15, 2021 · 0 comments · Fixed by #79
Closed
Tracked by #74

Accepting wire payments #75

dallashuggins opened this issue Nov 15, 2021 · 0 comments · Fixed by #79
Assignees
@dallashuggins
Labels
story Story

Comments

@dallashuggins
Copy link
Contributor

Overview

This is for building out the functionality to support accepting wire payments.

Additional context

A lot of the functionality was built for another project and just needs to be pulled into this project.

Including

  • API endpoints to support front-end functionality (creating bank accounts, getting the status, and getting wire instructions) and corresponding types.
  • Front-end endpoints and validation.
  • Simplify bid flow for wire payments (no need to gather credit car information)
  • Checkout flow for initiating creating an account for the wire payment
@dallashuggins dallashuggins added the story Story label Nov 15, 2021
@dallashuggins dallashuggins self-assigned this Nov 15, 2021
This was referenced Nov 15, 2021
Open
Merged
dallashuggins added a commit that referenced this issue Dec 9, 2021
@dallashuggins @smonn
[#75] Accepting wire payments (#79)
697ddbc 
* API endpoints

* New bid flow and bank accound flow

* Style and final changes to get bank account submission working

* Confirm bid + isGreaterThan fix

* Cleanup

* Adding FormValidation type export to avoid changing in multiple places for new validation

* Fixing conditional

* Fixing conditional and h4 inside p

* Email to user

* Text change

* Feature flag

* Cleanup

* Fixing boolean

* Simplified config

Co-authored-by: Simon Ingeson <44818+smonn@users.noreply.github.com>

* Removing null option

Co-authored-by: Simon Ingeson <44818+smonn@users.noreply.github.com>

* Simplifying conditional

* Fixing email subject line

* Fixing errors

* Amount, payment, and pack on wire transfer association + updating endpoints and types

* Not querying for unused params

* Price in USD and price in integer

* Sending pack template ID

* Supporting multiple packs and payments for the wire transfer and methods for scheduler

* Making externalId nullable and adding associations between packs/payments/banks

* Fixes and improvements to get the flow working

* [#76] Task for checking wire transfers (#123)

* Get wire payment task

* Conditional for cards

* Check pending bank account statuses

* Changing polling time, using ISO string, and small fixes

* Using currency and converting to integer in order to check the price of the incoming payment

* Converting float to int before passing to dinero

* Using external ID instead of id and not requiring a null externalId in conditional. Also removing currency from CMS since its not used

* Env example currency descriptions

* Fixing conditional so 3000 could be bid

* Bank failure removes claim from pack, minting pack is triggered by paid status

* Reverting change to type

* Using router instead of window

* Fixing build error and uppercase constant

* Removed todo

* Checkbox component

* Fixing rollback

* Bank account form style/content changes and todos in place of actions in wire payment flow

* Adding total to success form

* downgrade cms

* Fixes for style and functionality

* Fixing bid activity bug

Co-authored-by: Simon Ingeson <44818+smonn@users.noreply.github.com>
Co-authored-by: Simon Ingeson <simon@rocketinsights.com>
@dallashuggins dallashuggins mentioned this issue Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dallashuggins dallashuggins

Labels
story Story
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#75] Accepting wire payments deptagency/algomart
1 participant
@dallashuggins