Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use axe-core-api gem in axe-core-watir gem #118

Merged
merged 3 commits into from
Jul 20, 2020
Merged

fix: use axe-core-api gem in axe-core-watir gem #118

merged 3 commits into from
Jul 20, 2020

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Jul 16, 2020 •
edited by scurker
Loading

Note: This PR has a dependency on #113

Asides changing dependency structure, this PR also:

  • sets up all necessary Rake tasks
  • And formats code using rubocop

Closes issue:

  • NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for accessibility
  • Code is reviewed for security

@jeeyyy jeeyyy requested a review from AdnoC July 16, 2020 17:46
@jeeyyy jeeyyy mentioned this pull request Jul 16, 2020
Merged
3 tasks
@jeeyyy jeeyyy merged commit 16ab9cd into develop Jul 20, 2020
@jeeyyy jeeyyy deleted the fix/axe-core-watir branch July 20, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

@AdnoC AdnoC Awaiting requested review from AdnoC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @scurker