Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce top-level Rakefile for easier task management across packages #120

Merged
merged 6 commits into from
Jul 20, 2020

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Jul 16, 2020

Note: This PR has a dependency on, all of the below:

In order to be able to execute the top level Rakefile tasks that are introduced.
Given the lerna-esque/ monorepo directory structure followed, the top level task is purely a bunch of helper to invoke either scoped or all rake tasks of individual tasks.

Rest of the work in this PR is cleanup.

Closes issue:

  • NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for accessibility
  • Code is reviewed for security

@jeeyyy jeeyyy changed the title Chore/setup chore: introduce monorepo(esque) Rakefile for easier task management across packages Jul 16, 2020
@jeeyyy jeeyyy changed the title chore: introduce monorepo(esque) Rakefile for easier task management across packages chore: introduce top-level Rakefile for easier task management across packages Jul 16, 2020
Rakefile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@scurker
Copy link
Member

scurker commented Jul 17, 2020

Changes LGTM, just 2 questions.

@jeeyyy jeeyyy requested a review from scurker July 20, 2020 14:37
@jeeyyy jeeyyy merged commit 3554b86 into develop Jul 20, 2020
@jeeyyy jeeyyy deleted the chore/setup branch July 20, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants