fix(header-present): fail for headings with non-header role (#2306)

dequelabs · Jun 18, 2020 · b8ffb39 · b8ffb39
1 parent 58c8175
commit b8ffb39
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/checks/navigation/header-present.json b/lib/checks/navigation/header-present.json
@@ -2,7 +2,7 @@
 	"id": "header-present",
 	"evaluate": "has-descendant-evaluate",
 	"options": {
-		"selector": "h1, h2, h3, h4, h5, h6, [role=heading]"
+		"selector": "h1:not([role]), h2:not([role]), h3:not([role]), h4:not([role]), h5:not([role]), h6:not([role]), [role=heading]"
 	},
 	"metadata": {
 		"impact": "serious",

diff --git a/test/checks/navigation/header-present.js b/test/checks/navigation/header-present.js
@@ -75,6 +75,17 @@ describe('header-present', function() {
 		);
 	});
 
+	it('should return false if heading has a different role', function() {
+		var params = checkSetup(
+			'<h1 role="none" id="target">Some stuff and stuff</h1>'
+		);
+		assert.isFalse(
+			axe.testUtils
+				.getCheckEvaluate('header-present')
+				.apply(checkContext, params)
+		);
+	});
+
 	(shadowSupported ? it : xit)(
 		'should return true if heading is in shadow dom',
 		function() {