feat: update FR (french) translation file for next release #1089
Conversation
|
@ffoodd please update your branch, which should fix the build failures. |
|
Fantastic. Thanks Gaël. I'll let it set for review for a few days. We'll merge on Monday at the latest. |
locales/fr.json
Outdated
| @@ -49,6 +53,10 @@ | |||
| "description": "S’assure que les éléments <audio> ont des sous-titres", | |||
| "help": "Les éléments <audio> doivent avoir une psite de sous-titres" | |||
| }, | |||
| "autocomplete-valid": { | |||
| "description": "S’assure que l’attribut autocomplete est correct et adapté pour le champ de formulaire", | |||
| "help": "Lgattribut autocomplete doit être utilisé correctement" | |||
There was a problem hiding this comment.
Typo on the first word (should be L'attribut)
There was a problem hiding this comment.
French apostrophe ’ is done with Alt Gr + g on Ubuntu with French keyboard… explaining the g x)
locales/fr.json
Outdated
| @@ -305,12 +321,17 @@ | |||
| }, | |||
| "aria-required-children": { | |||
| "pass": "Les descendants ARIA requis sont présents", | |||
| "fail": "{{=it.data && it.data.length > 1 ? 'Descendants ARIA requis absents' : 'Descendant ARIA requis absent'}} : {{~it.data:value}} {{=value}}{{~}}" | |||
| "fail": "{{=it.data && it.data.length > 1 ? 'Descendants ARIA requis absents' : 'Descendant ARIA requis absent'}} : {{~it.data:value}} {{=value}}{{~}}", | |||
| "incomplete": "{{=it.data && it.data.length > 1 ? 'Les descendants' : 'Le descendant'}} requièrent le rôle ARIA : {{~it.data:value}} {{=value}}{{~}}" | |||
There was a problem hiding this comment.
requièrent is correct with plural but not otherwise.
'Les descendants' : 'Le descendant'}} requièrent should become something like:
'Les descendants requièrent' : 'Le descendant requiert'}}
locales/fr.json
Outdated
| @@ -279,6 +291,10 @@ | |||
| "pass": "Les attributs ARIA sont utilisés correctement pour le rôle défini", | |||
| "fail": "{{=it.data && it.data.length > 1 ? 'Attributs ARIA non autorisés' : 'Attribut ARIA non autorisé'}} : {{~it.data:value}} {{=value}}{{~}}" | |||
| }, | |||
| "aria-allowed-role": { | |||
| "pass": "Le rôle ARIA role est autorisé pour l’élément donné", | |||
| "fail": "{{=it.data && it.data.length > 1 ? 'Les rôles' : 'Le rôle'}} {{=it.data.join(', ')}} {{=it.data && it.data.length > 1 ? 'ne sont' : 'n’est'}} pas autorisé pour l’élément donné" | |||
There was a problem hiding this comment.
Conjugation to correct:
{{=it.data && it.data.length > 1 ? 'ne sont pas autorisés' : 'n’est pas autorisé'}}
instead of:
{{=it.data && it.data.length > 1 ? 'ne sont' : 'n’est'}} pas autorisé
|
@ffoodd, I will no longer participate in translation updates. But despite this problem, good work @ffoodd for the web accessibility in French. |
locales/fr.json
Outdated
| @@ -279,6 +291,10 @@ | |||
| "pass": "Les attributs ARIA sont utilisés correctement pour le rôle défini", | |||
| "fail": "{{=it.data && it.data.length > 1 ? 'Attributs ARIA non autorisés' : 'Attribut ARIA non autorisé'}} : {{~it.data:value}} {{=value}}{{~}}" | |||
| }, | |||
| "aria-allowed-role": { | |||
| "pass": "Le rôle ARIA role est autorisé pour l’élément donné", | |||
There was a problem hiding this comment.
"role" appears twice: a translation of Ensures role attribute has an appropriate value for the element could use the word attribute for one of them.
L'attribut ARIA role (…) for example, edit: or shorter and closer to original sentence L'attribut role.
Review 10% (50 max) of the following (Product manager only): - [x] feat: Update FR (french) translation file for 3.1 release (#1089) (4a5cad0) - [x] chore: Fix example dependency mistake (#1094) (6af5733) - [x] fix: Do not require media captions / descriptions (#1075) (289f623) - [x] feat(aria-role): Remove non-existing "text" role (#1069) (67ec1f5) - [x] Merge pull request #1017 from dequelabs/aria-getrole (f64ff10) - [x] chore: remove `.jshintrc` files (#1028) (03b3327) - [x] chore: ability to add external libs (axios) (0957dab) - [x] Merge pull request #985 from dequelabs/git-update (54b0b60)
Updating french translation file with new strings.
Ping:
For french proofreading.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)