feat(aria-role): Remove non-existing "text" role #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
previously requested changes
Aug 16, 2018
WilcoFiers
changed the title
jeeyyy
approved these changes
Aug 21, 2018
|
Because of the way
This is very misleading, or is this intentional? Also means for PR from yourself, you cannot merge until one of the other code owner(s) have approved it. |
dylanb
approved these changes
Aug 22, 2018
|
@JKODU This is intentional. Because of the complexity of axe-core we want at least one of the code owners to approve PRs to develop. |
stephenmathieson
added a commit
that referenced
this pull request
Aug 22, 2018
…re into circleci-releases * 'circleci-releases' of ssh://github.com/dequelabs/axe-core: feat(aria-role): Remove non-existing "text" role (#1069)
WilcoFiers
added a commit
that referenced
this pull request
Aug 27, 2018
Review 10% (50 max) of the following (Product manager only): - [x] feat: Update FR (french) translation file for 3.1 release (#1089) (4a5cad0) - [x] chore: Fix example dependency mistake (#1094) (6af5733) - [x] fix: Do not require media captions / descriptions (#1075) (289f623) - [x] feat(aria-role): Remove non-existing "text" role (#1069) (67ec1f5) - [x] Merge pull request #1017 from dequelabs/aria-getrole (f64ff10) - [x] chore: remove `.jshintrc` files (#1028) (03b3327) - [x] chore: ability to add external libs (axios) (0957dab) - [x] Merge pull request #985 from dequelabs/git-update (54b0b60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove role=text was proposed for ARIA 1.1 but never made it in. It shouldn't be allowed by axe-core. Here's a list of all valid roles: https://www.w3.org/TR/wai-aria-1.1/#role_definitions
Closes #1048
Reviewer checks
Required fields, to be filled out by PR reviewer(s)