fix: Do not require media captions / descriptions #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
reviewed
Aug 21, 2018
build/tasks/validate.js
Outdated
| @@ -27,6 +27,27 @@ function hasUniqueId() { | |||
| }; | |||
| } | |||
|
|
|||
| function hasTwoOutcomes(messages) { | |||
There was a problem hiding this comment.
Looks like this is normalising multiple outcomes, should change function name to something generic like normaliseOutcomes or hasMultipleOutcomes rather than exactly Two?
jeeyyy
reviewed
Aug 21, 2018
build/tasks/validate.js
Outdated
| } | ||
| // propferties: { |
There was a problem hiding this comment.
minor: 🤣 propferties, know it is commented.... delete instead?
dylanb
requested changes
Aug 21, 2018
build/tasks/validate.js
Outdated
| } | ||
| // propferties: { |
lib/checks/media/caption.json
Outdated
| @@ -5,7 +5,6 @@ | |||
| "impact": "critical", | |||
| "messages": { | |||
| "pass": "The multimedia element has a captions track", | |||
| "fail": "The multimedia element does not have a captions track", | |||
| "incomplete": "A captions track for this element could not be found" | |||
There was a problem hiding this comment.
Could make this message more explicit about what to do to check whether an alternative exists
dylanb
approved these changes
Aug 23, 2018
jeeyyy
approved these changes
Aug 23, 2018
WilcoFiers
added a commit
that referenced
this pull request
Aug 27, 2018
Review 10% (50 max) of the following (Product manager only): - [x] feat: Update FR (french) translation file for 3.1 release (#1089) (4a5cad0) - [x] chore: Fix example dependency mistake (#1094) (6af5733) - [x] fix: Do not require media captions / descriptions (#1075) (289f623) - [x] feat(aria-role): Remove non-existing "text" role (#1069) (67ec1f5) - [x] Merge pull request #1017 from dequelabs/aria-getrole (f64ff10) - [x] chore: remove `.jshintrc` files (#1028) (03b3327) - [x] chore: ability to add external libs (axios) (0957dab) - [x] Merge pull request #985 from dequelabs/git-update (54b0b60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require media captions / descriptions
Closes #816
Reviewer checks
Required fields, to be filled out by PR reviewer(s)