Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axe-Core 3.2.0 added an ES6 Promise polyfill that overwrites native promise behavior #1468

Closed
cscrosati opened this issue Apr 2, 2019 · 2 comments · Fixed by #1470
Closed
Labels
core Issues in the core code (lib/core) fix Bug fixes

Comments

@cscrosati
Copy link

After updating to 3.2.0/3.2.2 of axe-core, I noticed a lot of our QUnit test suite failed in interesting ways, where Promise resolution was involved.

After debugging, it turned out when loading axe-core, a promise polyfill was loaded that overrides the native promise behavior. Not only that, it overrides our own polyfill implementation when we use one ourselves.

Can the polyfill only be used if window.Promise doesn't exist? Right now, it overwrites what is in place.

@cscrosati cscrosati changed the title Axe-Core 3.2.0 added an ES6 Promise polyfills that overwrites native promise behavior Axe-Core 3.2.0 added an ES6 Promise polyfill that overwrites native promise behavior Apr 2, 2019
@WilcoFiers
Copy link
Contributor

@cscrosati Thanks for reporting. That definitely wasn't the intent. @straker can you create a fix for this?

@cscrosati
Copy link
Author

BTW, thanks for fixing so promptly! :) Which official release should I expect this to be in?

@WilcoFiers WilcoFiers added this to the Axe-core 3.3 milestone May 1, 2019
@WilcoFiers WilcoFiers added fix Bug fixes core Issues in the core code (lib/core) labels Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) fix Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants