Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rule label-content-name-mismatch to filter by widget roles #2019

Closed
jeeyyy opened this issue Feb 4, 2020 · 4 comments
Closed

Update rule label-content-name-mismatch to filter by widget roles #2019

jeeyyy opened this issue Feb 4, 2020 · 4 comments
Assignees
@jeeyyy
Labels
ACT Rules

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Feb 4, 2020 •
edited
Loading

Expectation:
Below example should be inapplicable.

<div role="tooltip" aria-label="OK">Next</div>

Actual: Axe fails the above example

Motivation:
Needed for ACT Rules implementation. Rule in question: https://act-rules.github.io/rules/2ee8b8


axe-core version: X.Y.Z
axe-webdriver, extension or other integration version: X.Y.Z

Browser and Assistive Technology versions

For Tooling issues:
- Node version: XX  
- Platform:
@jeeyyy jeeyyy self-assigned this Feb 4, 2020
@straker
Copy link
Contributor

straker commented Feb 4, 2020

We already filter by widget roles, but tooltip is included in the lookup tale in rolesOfType (it shouldn't be)

@jeeyyy jeeyyy changed the title Update rule label-name-content-mismatch to filter by widget roles Update rule label-content-name-mismatch to filter by widget roles Feb 5, 2020
@jeeyyy jeeyyy mentioned this issue Feb 5, 2020
Merged
2 tasks
@jeeyyy jeeyyy added the fix Bug fixes label Feb 5, 2020
@jeeyyy jeeyyy added the has pr label Feb 18, 2020
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Feb 26, 2020

PR has been merged. Closing issue.

@jeeyyy jeeyyy closed this as completed Feb 26, 2020
@jeeyyy jeeyyy reopened this Feb 28, 2020
@jeeyyy jeeyyy removed the has pr label Feb 28, 2020
@padmavemulapati
Copy link

Verified with latest axe-coconut(v4.3.0.06000), the test file
` Next

Ok
RSS Feed
Foo Restaurant
` giving inapplicable . ![image](https://user-images.githubusercontent.com/47409579/75665780-b6cf9d80-5c9a-11ea-9eec-1d4d487bc3e4.png)

@jeeyyy jeeyyy changed the title Update rule label-content-name-mismatch to filter by widget roles [Docs] Update rule label-content-name-mismatch to filter by widget roles Mar 2, 2020
@jeeyyy jeeyyy removed the fix Bug fixes label Mar 2, 2020
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Mar 16, 2020

No documentation necessary. Closing issue. QA verified.

@jeeyyy jeeyyy closed this as completed Mar 16, 2020
@jeeyyy jeeyyy changed the title [Docs] Update rule label-content-name-mismatch to filter by widget roles Update rule label-content-name-mismatch to filter by widget roles Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
ACT Rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@straker @jeeyyy @padmavemulapati