fix(label-content-name-mismatch): ignore non widget aria role(s) & do not use deprecated lookupTable.rolesOfType
#2022
Conversation
jeeyyy
changed the title
widget aria role(s) for rule label-content-name-mismatchwidget aria role(s) for rule
|
Thanks for posting the new sizes. With axe-core 4.0 being the next phase, I want to introduce a size budget (#1930). Adding 100 KB of / 60 KB (min) to axe-core seems a bit much just to fix a hard-coded list we have already. I know we've talked about aria-query before and using it in place of our lookup table entirely. @WilcoFiers is that something we could do for 4.0? |
|
I agree with @WilcoFiers and @straker. Adding 100k just to fix a single bug probably isn't worth it. |
|
Ended up removing the array History points to this snapshot when this listing was added. From memory I believe there was an ask to not touch/ alter the lookup table when this PR was authored. |
|
@WilcoFiers probably needs to approve removing the list as he'll have the most knowledge of why it was created in the first place. |
| * ] | ||
| * There are some differences against specs, hence the below listing was made | ||
| */ | ||
| lookupTable.rolesOfType = { |
There was a problem hiding this comment.
Taking this out could break custom rules. Please leave it in, label it as deprecated, and make sure to include the word "deprecated" in the title of the PR so it appears in the changelog.
jeeyyy
changed the title
widget aria role(s) for rulewidget aria role(s) and do not use deprecated lookupTable.rolesOfType
jeeyyy
changed the title
widget aria role(s) and do not use deprecated lookupTable.rolesOfTypewidget aria role(s) & do not use deprecated lookupTable.rolesOfType
…do not use deprecated `lookupTable.rolesOfType` (#2022) * fix: ignore non-widget roles for rule label-content-name-mismatch * update helper fn for getting role type * update aria-query * rollback using aria-query * updates * update
Updated lookUpTable with roles of type
widget.Closes issue:
label-content-name-mismatchto filter by widget roles #2019Reviewer checks
Required fields, to be filled out by PR reviewer(s)