excluding "valid-lang" rule from a11ycheck #219

devarshipant · 2016-08-30T13:23:04Z

Hi All,

On executing the script to exclude the valid-lang check, the lang test still runs in the console despite disabling it under 'rules.'

Any advise will be appreciated.

thanks!

Here it is:
axe.a11yCheck(document, {
runOnly: {
type: "tag",
values: ["wcag2a"]
},
"rules": {
"color-contrast": { enabled: true },
"valid-lang": { enabled: false },
}
}, function(results) {
console.log(results);
});

marcysutton · 2016-08-30T15:36:25Z

That rule was split in two and changed names. You found something we need to fix in our documentation! Here are the correct rules to disable HTML lang:

html-has-lang
html-lang-valid

devarshipant · 2016-08-30T17:28:55Z

html-lang-valid or html-lang-invalid?

Thanks!

marcysutton · 2016-08-30T19:26:07Z

Actually, I misspoke. It was broken into three separate rules. html-has-lang and html-lang-valid check the HTML element, while valid-lang checks everything else. Can you elaborate with more details about the results returned?

devarshipant · 2016-08-31T10:59:33Z

I am interested in running snippet #4 under https://github.com/dequelabs/axe-core/blob/master/doc/API.md#options-parameter-examples -

{
runOnly: {
type: "tag",
values: ["wcag2a"]
},
"rules": {
"color-contrast": { enabled: true },
"valid-lang": { enabled: false }
}
}

I haven’t been able to run the set. In addition, when I pass the selector for the entire doc and enable all rules, it only runs under IE 9.

marcysutton · 2016-08-31T22:15:20Z

I ran a test against some basic HTML markup with that config and I don't see valid-lang running at all. Can you post the HTML you're running it against? Here is my config, which I embedded in a script tag in an HTML document:

var config = {
  runOnly: {
    type: "tag",
    values: ["wcag2a"]
  },
  "rules": {
    "color-contrast": { enabled: true },
    "valid-lang": { enabled: false }
  }
}
axe.a11yCheck(document, config, function(results) {
  console.dir(results.violations);
});

With this markup:

<html lang="en">
<head>
    <title>Page title</title>
</head>
<body>
<header role="banner">
  <h1>HEY</h1>
</header>
<main role="main">
<div lang="derp">
  <a href="#menu" style="color:#ccc;">
    Menu
  </a>
</div>
</main>
</body>
</html>

That only triggers one failure: color-contrast. valid-lang is skipped, per the config. And again, it's looking at lang in the body–not at the HTML tag. That is covered by two separate rules.

In addition, when I pass the selector for the entire doc and enable all rules, it only runs under IE 9.

That sounds like a separate issue, definitely requiring more details.

devarshipant · 2016-09-01T16:33:03Z

Ok, the valid-lang works. I have attached the html file. I interesting to note the color contrast violation that gets flagged, which is same as given by WAT Analyzer. Also, note another rule I added “skip-link:” {enabled: true }, but did not see it flagged.

Thanks!

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. **This update includes a security fix.** - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Michael <45568605+michael-siek@users.noreply.github.com>

marcysutton closed this as completed Sep 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

excluding "valid-lang" rule from a11ycheck #219

excluding "valid-lang" rule from a11ycheck #219

devarshipant commented Aug 30, 2016

marcysutton commented Aug 30, 2016

devarshipant commented Aug 30, 2016 •

edited by dylanb

marcysutton commented Aug 30, 2016

devarshipant commented Aug 31, 2016 •

edited by dylanb

marcysutton commented Aug 31, 2016 •

edited

devarshipant commented Sep 1, 2016 •

edited by dylanb

excluding "valid-lang" rule from a11ycheck #219

excluding "valid-lang" rule from a11ycheck #219

Comments

devarshipant commented Aug 30, 2016

marcysutton commented Aug 30, 2016

devarshipant commented Aug 30, 2016 • edited by dylanb

marcysutton commented Aug 30, 2016

devarshipant commented Aug 31, 2016 • edited by dylanb

marcysutton commented Aug 31, 2016 • edited

devarshipant commented Sep 1, 2016 • edited by dylanb

devarshipant commented Aug 30, 2016 •

edited by dylanb

devarshipant commented Aug 31, 2016 •

edited by dylanb

marcysutton commented Aug 31, 2016 •

edited

devarshipant commented Sep 1, 2016 •

edited by dylanb