Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop leaking uuid into the global namespace #4

Closed
dylanb opened this issue Jun 15, 2015 · 0 comments
Closed

stop leaking uuid into the global namespace #4

dylanb opened this issue Jun 15, 2015 · 0 comments
Labels
core Issues in the core code (lib/core) fix Bug fixes
Milestone
1.1.0

Comments

@dylanb
Copy link
Contributor

dylanb commented Jun 15, 2015

The dependency on the node-uuid module is leaking things into the window namespace in a browser and into the module.exports when required in Node.js

We should not leak anything into any namespaces unintentionally
@dsturley dsturley added fix Bug fixes core Issues in the core code (lib/core) labels Jun 15, 2015
@dsturley dsturley modified the milestone: 1.1.0 Jun 15, 2015
@dsturley dsturley mentioned this issue Jun 15, 2015
Merged
dylanb added a commit that referenced this issue Jun 15, 2015
@dylanb
Merge pull request #16 from dsturley/gh-4-uuid
4e59515 
Use forked node-uuid without explicitly publish to global object
marcysutton pushed a commit that referenced this issue Jun 27, 2016
@dylanb
Merged in wilcofiers/axe-core/patching (pull request #4)
ac24193 
Patching
@devarshipant devarshipant mentioned this issue Aug 31, 2016
Closed
devaradhanm pushed a commit to devaradhanm/axe-core that referenced this issue Nov 27, 2019
@dylanb
Merge pull request dequelabs#4 from dequelabs/remove-puppeteer-core-dep
478ddf1 
fix: do not depend on `puppeteer-core`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues in the core code (lib/core) fix Bug fixes
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@dylanb @dsturley