Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout-table): check for presentation, none roles and isfocusable for matches #828

Merged
merged 3 commits into from
Apr 11, 2018

Conversation

waabid
Copy link
Contributor

@waabid waabid commented Apr 4, 2018

@waabid waabid changed the title ix(layout-table): check for presentation, none roles and isfocusable for matches fix(layout-table): check for presentation, none roles and isfocusable for matches Apr 4, 2018
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! It would be good to add some truthy matches tests, and something covering the !isFocusable bit.

@WilcoFiers
Copy link
Contributor

Should we have this use the role-presentation and role-none checks instead?

@waabid
Copy link
Contributor Author

waabid commented Apr 9, 2018

@WilcoFiers I believe we do not want to run the rule on them in the case they have those roles; using those checks would still end up resulting in evaluating the current logic of the rule which is not applicable in these cases.

@marcysutton I've made the changes for more truthy tests and focusable elements: let me know what you think.

@waabid waabid closed this Apr 9, 2018
@waabid waabid reopened this Apr 9, 2018
@WilcoFiers
Copy link
Contributor

@waabid Fair enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants