Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): Fix Japanese translation #1291

Merged
merged 2 commits into from
Dec 30, 2018

Conversation

honoka-h
Copy link
Contributor

Attribute name is changed to back to English (it was supposed to remain in English).

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: << Name here >>

@honoka-h honoka-h requested a review from a team as a code owner December 26, 2018 08:51
@marcysutton
Copy link
Contributor

Test failure is unrelated:

>> URL: http://localhost:9876/test/integration/full/landmark-banner-is-top-level/landmark-banner-is-top-level-fail.html
>> Describe: landmark-banner-is-top-level test fail
>> it "before all" hook
>> Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

Warning: Task "test-webdriver:chrome-mobile" failed.� Use --force to continue.

Aborted due to warnings.

    >> 
    Warning: Task "parallel:browser-test" failed.� Use --force to continue.

@WilcoFiers WilcoFiers merged commit f450176 into dequelabs:develop Dec 30, 2018
@honoka-h honoka-h deleted the mlca11y-ja_update branch January 7, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants