Enable best practices #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
BREAKING CHANGE: Skip-link rule no longer requires skip lins with a focusable target.
|
@WilcoFiers what was the rationale behind not requiring a focusable target? |
|
@dylanb Chrome used to have the issue that if you had a skiplink to a non-focusable element, it would just blur in place, and the next item in the focus order would just be whatever comes after the skiplink. Other browsers blurred on the target of the skiplink, so that the next focusable element would be the thing after the target of the skiplink. After some testing it looks like this issue has been resolved, so skiplinks now work everywhere, regardless of if the target is focusable or not. |
dylanb
approved these changes
Nov 24, 2017
|
Excellent! Thank you all! |
marcysutton
pushed a commit
that referenced
this pull request
Dec 8, 2017
Merge pull request #612 from dequelabs/bp-enabled BREAKING CHANGE: Skip-link rule no longer requires skip links with a focusable target. Enable best practices
|
I merged this into Oh crud, and I just saw the comment. I'll remove it in another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #515. This should not be put in develop-2x
BREAKING CHANGE: Skip-link rule no longer requires skip links with a focusable target.