This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Bump axe-core version to 3.2.2 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelyoungstrom
changed the title
michaelyoungstrom
force-pushed
the
youngstrom/bump-axe-core
branch
4 times, most recently
from
66895d1
to
1cbb48e
Compare
jmbowman
reviewed
Mar 19, 2019
lib/custom_a11y_rules.js
Outdated
| @@ -116,7 +116,8 @@ var customRules = { | |||
| 'fail': 'all <nav> elements MUST have aria-label or aria-labelledby attribute' | |||
| } | |||
| }, | |||
| evaluate: function(node, options) { | |||
| evaluate: function(node, option) { | |||
There was a problem hiding this comment.
Did this need to be changed? It looks like all the other checks still use "options".
There was a problem hiding this comment.
woops. good catch! That was accidental.
michaelyoungstrom
force-pushed
the
youngstrom/bump-axe-core
branch
from
1cbb48e
to
74d5a89
Compare
jmbowman
approved these changes
Mar 19, 2019
michaelyoungstrom
force-pushed
the
youngstrom/bump-axe-core
branch
from
62b5a27
to
3d5e8f3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1.0to3.2.2axe.a11yAudithas been removed in favor ofaxe.runnav-aria-label-valueandnav-aria-label-present, I was seeing failures saying:TypeError: axe._tree is undefined in /home/travis/build/edx/edx-custom-a11y-rules/node_modules/axe-core/axe.min.js. I followed what the axe-core repo does for this, and defined theaxe._treeinside the test: Link to example in the axe-core repoaxe.commons.dom.isFocusabledid an early check to see if an element was null: 1.1.0 code link, but not anymore: 3.2.2 code link. So I added a null check to fix some failures I was seeing.skip-link-fail.htmlwas actually passing: Link to PR that changed this check. So I changed the html file to represent a valid failure.