Repairs cluster-name flag #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly detected cluster name
derailed
requested changes
Apr 29, 2021
| @@ -377,13 +377,21 @@ func (p *Popeye) dumpPrometheus() error { | |||
| return pusher.Add() | |||
| } | |||
|
|
|||
| func (p *Popeye) getClusterName() string { | |||
| if *p.flags.InClusterName != "" { | |||
There was a problem hiding this comment.
@danibaeyens We should check for nil ptr here prior to the dereference in case the flag is not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154.
cluster-name flag always overrides the automatically detected cluster name. Specially useful in cases where popeye is executed from a CronJob in the cluster via a ServiceAccount, and it doesn't use a config file.