fix terminal colors display #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlereste
force-pushed
the
fix_color_display
branch
from
739731c
to
fda2671
Compare
tlereste
force-pushed
the
fix_color_display
branch
from
fda2671
to
f9283ef
Compare
|
@tlereste Doh!! Thank you for this PR! I think I understand your initial issue now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88
There is an extra semicolon in RGB color function. This semicolon prevent colors to be displayed in terminal. (Debian in my case)
See https://stackoverflow.com/a/15712766 for explaination.