Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Add context menu for playlist #13

Closed
derat opened this issue Apr 16, 2021 · 2 comments
Closed

Add context menu for playlist #13

derat opened this issue Apr 16, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@derat
Copy link
Owner

derat commented Apr 16, 2021

It'd be nice if a context menu were displayed when right-clicking on a song in the playlist. It should probably have Play, Remove, and Truncate items.

@derat derat added the enhancement New feature or request label Apr 16, 2021
@derat derat self-assigned this Apr 16, 2021
derat added a commit that referenced this issue Oct 31, 2021
Update the dialog-manager component to support displaying
context menus, and make the song-table component emit 'menu'
events when song rows are right-clicked.

Also update music-player to create menus with 'Play' and
'Debug' items. I'm going to add 'Remove' and 'Truncate' in a
later change since music-player's playlist-management code
is pretty lacking right now.
derat added a commit that referenced this issue Oct 31, 2021
Update the dialog-manager component to support displaying
context menus, and make the song-table component emit 'menu'
events when song rows are right-clicked.

Also update music-player to create menus with 'Play' and
'Debug' items. I'm going to add 'Remove' and 'Truncate' in a
later change since music-player's playlist-management code
is pretty lacking right now.
@derat derat closed this as completed in 80fd93d Oct 31, 2021
@derat derat reopened this Nov 13, 2021
@derat
Copy link
Owner Author

derat commented Nov 13, 2021

Minor improvement: the row being referenced by the context menu should be highlighted.

@derat
Copy link
Owner Author

derat commented Nov 13, 2021

It might also be nice if search results had a context menu with the 'Debug' item.

derat added a commit that referenced this issue Nov 13, 2021
See #13. Also make utils.wait() sleep 50 ms rather than 100
ms to try to make races less likely in web tests.
@derat derat closed this as completed in c4baa6b Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant