Fix bookmarks sort issue #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskePit
commented
Nov 20, 2017
| @@ -77,6 +77,7 @@ m_hContainer(hwnd) | |||
| m_hActiveListView = NULL; | |||
| m_hTabFont = NULL; | |||
| m_hNextClipboardViewer = NULL; | |||
| m_hLanguageModule = NULL; | |||
There was a problem hiding this comment.
I had a crash without this line so I'll leave it here as well although it has nothing common with the problem in the topic.
|
Hi @AskePit, the changes look good. One small change: could you move the m_hLanguageModule change out into a separate pull request? That will ensure that this pull request only contains the modifications necessary to fix the bookmark sorting issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm a member of the Pinguem.ru competition on finding errors in open source projects.
I found an issue with Explorer++ bookmarks where you're not able to sort already bookmarked entities. To reproduce the bug follow these steps:
Ctrl+Dshortcut either by executingBookmarks -> Bookmark This Tab...command.Manage Bookmarksdialog window either viaCtrl+Beither by executingBookmarks -> Manage Bookmarks...command.Views -> Sort -> Sort by [sort-criteria]commands. It does nothing — entities are shown in order as they were added.Solution is simple — there was a typo which was succesfully found by PVS-Studio analyzer: