Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI upgrade broken when managed #476

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

BenElgar
Copy link
Contributor

@BenElgar BenElgar commented Nov 4, 2021

No description provided.

@BenElgar BenElgar enabled auto-merge (squash) November 4, 2021 14:10
@BenElgar BenElgar merged commit 373d203 into main Nov 4, 2021
@BenElgar BenElgar deleted the fix-ui-broken-when-managed branch November 4, 2021 14:12
let upgrading = false;

const doUpgrade = async () => {
if (isManaged) {
alert(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have nothing better than alert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not right now. @jwmza

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal system coming imminently, I'm going to wrap up some in-flight things first though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants