Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the same issues than #26, but goes a little further.
Included:
There are several ways this could have been implemented, feel free to comment if you think the one I went with does not fit well. Indeed it changes the way links are created because of the embedded link field.
The embedded field could be avoided at the cost of a less elegant implementation, but if you don't want to break the public API that would be the way to go.
I have another series of improvements I am working on that I want to propose (mainly on errors) and some of them cannot be done without changing the current data structure. I am therefore interested in your opinion on the matter to see if we can incorporate breaking changes in v1 or in a separate branch.