-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SimpleEngine #35
Improve SimpleEngine #35
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #35 +/- ##
============================================
- Coverage 84.69% 84.05% -0.65%
- Complexity 109 110 +1
============================================
Files 12 12
Lines 392 395 +3
============================================
Hits 332 332
- Misses 60 63 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Maybe we could display validation message "try again later" for the case of having too many "open" captchas for this user? |
Yes, but this would require to
The design would smell, wouldn't it ? |
I wonder if we need maxRule and could just move all of it to validation rule |
What's the first count? On Display? Maybe we can make validation in a way that we only need get count once |
SimpleEngine
Improve
SimpleEngine
to make it harder to guess with random values.Customizable deadlock duration
Allow custom deadlock duration in case
maxPerUser
is exceeded.However, this is an "at most" threshold, since the client IP or the session ID may change in the meanwhile.
Resigned : display smart error message as the captcha image.
No idea if this feature would really be useful, but I scratched my head to display simple text as an image. I wrote (smelling) code which doesn't even pass coding standards.
I've given up because I don't know how to do and have already wasted too much time for this detail. You can have a look to zachee54@f3d1cdd if you're interested in.