3.7 deprecated warnings #6
Conversation
|
Seems like the tests then fail, do we also need to load the TwigView plugin then maybe? |
Looks like bootstrapping logic is a bit different with |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage 77.29% 77.29%
Complexity 361 361
=========================================
Files 17 17
Lines 850 850
=========================================
Hits 657 657
Misses 193 193Continue to review full report at Codecov.
|
tests/bootstrap.php
Outdated
| @@ -25,6 +25,7 @@ | |||
| define('CAKE', CORE_PATH . APP_DIR . DS); | |||
|
|
|||
| require dirname(__DIR__) . '/vendor/autoload.php'; | |||
| require CONFIG . 'bootstrap.php'; | |||
There was a problem hiding this comment.
should this be after the core one maybe? or is the order ok like this?
There was a problem hiding this comment.
should this be after the core one maybe? or is the order ok like this?
Let's move it to be safe
| @@ -43,5 +44,5 @@ | |||
|
|
|||
| Cake\Core\Configure::write('debug', true); | |||
|
|
|||
| Cake\Core\Plugin::load('CakeDto', ['path' => ROOT . DS, 'autoload' => true, 'bootstrap' => true]); | |||
| Cake\Core\Plugin::getCollection()->add(new CakeDto\Plugin()); | |||
There was a problem hiding this comment.
Just to be clear: This is also available in 3.6 right?
The tests at least say it is - so all good for BC :)
There was a problem hiding this comment.
Just to be clear: This is also available in 3.6 right?
Yeah, it's available in 3.6
Plugin::load()is marked as deprecated in 3.7, usePlugin::getCollection()->add()instead.