add google places helper #36
Conversation
Add a helper for google places and add libraries options to google Map helper
| * | ||
| * @return string divContainer | ||
| */ | ||
| public function input( $fieldName, array $fieldOptions = [], $googleOptions = [] ) { |
There was a problem hiding this comment.
Yes, I would like to use the same methods as FormHelper
I can remove this or add @deprecated
| * | ||
| * @return string divContainer | ||
| */ | ||
| public function control( $fieldName, $fieldOptions = [], $googleOptions = [] ) { |
There was a problem hiding this comment.
arrays should have typehints
also please check CS issues
| * @param $id string the id of the input field | ||
| * @param array $options associative array of settings for places.Autocomplete | ||
| */ | ||
| private function _script( $id, $options = [] ) { |
There was a problem hiding this comment.
protected and array typehint
| //http://ajax.googleapis.com/ajax/libs/jquery/1/jquery.min.js | ||
| } | ||
| // still not very common: http://code.google.com/intl/de-DE/apis/maps/documentation/javascript/basics.html | ||
| if (false && !empty($this->_runtimeConfig['autoScript']) && !$this->_gearsIncluded) { |
There was a problem hiding this comment.
if false => we can remove this part then?
| @@ -112,6 +111,8 @@ function initialize() { | |||
|
|
|||
| $script = 'jQuery(document).ready(function() {' . $js . '});'; | |||
|
|
|||
| $this->Html->scriptBlock($script, ['block' => true]); | |||
| $this->Html->scriptBlock( $script, [ 'block' => true ] ); | |||
There was a problem hiding this comment.
You should run the sniffer instead as documented, this is all invalid CS :)
|
Sure you can the |
|
i had included codesniffer standard psr2 into phpStorm. the composer commands are new for me. Looks like these are other standards. |
| * @return string divContainer | ||
| */ | ||
| public function control($fieldName, array $fieldOptions = [], array $googleOptions = []) { | ||
| $id = isset($fieldOptions['id']) && $fieldOptions['id'] != '' ? $fieldOptions['id'] : $fieldName; |
There was a problem hiding this comment.
!empty(fieldOptions['id']) is shorter than both checks. 0 is not a valid id anyway right?
|
|
||
| $html = $this->Form->control($fieldName, $fieldOptions); | ||
| $html .= $this->Form->hidden("{$fieldName}_lat", ['id' => "{$id}_lat"]); | ||
| $html .= $this->Form->hidden("{$fieldName}_lon", ['id' => "{$id}_lon"]); |
There was a problem hiding this comment.
lng is usually used for longitude shortform in this plugin.
|
Can we have a small test for the new functionality and helper? |
|
I will have a look at your cakephp-sandbox and build some example later at home. |
|
Any update here? |
|
ping @mh-SimTEC |
Add a helper for google places and add libraries options to google Map helper
I don't know if i have fully understand how you include the google api.