Don't pass arrays to is_dir() #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
reviewed
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=========================================
Coverage 57.74% 57.74%
Complexity 658 658
=========================================
Files 35 35
Lines 2123 2123
=========================================
Hits 1226 1226
Misses 897 897 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default config file contains the settings
pluginsandignoredTaskswhich are arrays.The rendering of the edited template fails because arrays must not be passed to
is_dir().