-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symphosize improvements #84
Symphosize improvements #84
Conversation
I see the tests are failing because of our missing |
I like the changes. |
I'll update the fixtures tomorrow, I'll also push a slight change to our exception catcher to use |
But this 2.x code is not namespaced, thus it should not matter. |
However the libs we use are often namespaced. For example I am having trouble with the Google API throwing and Error, and using |
* @param string $direction Direction of migration process (up or down) | ||
* @return bool Should process continue | ||
*/ | ||
public function after($direction) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if you could run the sniffer over this to auto-fix the comment indentation.
Just a note, that I am still planning on making these changes. Will need a couple more days |
Cool |
]; | ||
$this->_next_priority = 5; // reset to default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_nextPriority
This includes our changes to the Queue plugin. There are two main changes included with this pull request.
$this->QueuedTask->nextPriority(2)->createJob('YourSuperCoolTask', [ 'some_id' => '12345', ]);
I am open to suggestion on how we can make this a useful contribution to the plugin. Any feedback is welcome.