feh -x --borderless not removing Window border? #137
Comments
Compiling feh with -O2 appears to cause the mwmhints struct to get
padded. When casting it to (unsigend char *) and passing that to
XChangeProp, the values were getting corrupted.
For example,
$ feh -x foo.png
$ xprop | grep MOTIF
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x0, 0xeb277ce8, 0x838fd4c8, 0x1
^^^^^^^^^^
should be 0
This patch copies the values from the struct into an unsigned char * buffer explicitly.
|
The problem is that mwmhints is not initialized, and contains garbage after the flags field. I have a patch but it's not obvious to me how to attach it to this comment. You can pick it up at http://jim.rees.org/feh.diff . |
|
I mentioned this issue on the Openbox mailing list and Brian submitted the feh-mwmhints3.patch Now I see Jim-rees has submitted a different patch, feh.diff, so which one should we use? Thanks |
|
Use feh-mwmhints3.patch. It is the same as pull request #139, which includes Jim's patch. |
|
Brian Mattern wrote: Use feh-mwmhints3.patch. It is the same as pull request #139, which Agreed. Thanks. I'm left wondering why struct mwmhints isn't defined in some system include |
|
Confirmed and merged, thanks! |
Hi,
-x & --borderless seem pretty self explanatory, run feh -x or --borderless /path/to/wallpaper and feh opens up without any window border, correct?
If so this is not working 2.9.3...
I still get a Window/Title bar saying;
feh [1of41] - /home/foo/Wallpaper/A Bug.jpg
I just want to see a borderless window, I'm assuming I'm suppose to be able to do this with those commands?
I only run Openbox 3.5.0 as my DE, seems as though the commands don't over ride the Openbox themes to remove the border...
Thank you
The text was updated successfully, but these errors were encountered: