-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't open tga images with palette #491
Comments
Since I've now done that myself (and there's a bit of setup involved), I can get it submitted to Imlib2 for you, @rofl0r, is that okay? The case marked as |
i updated the patch with some security code so we don't end up in an unexpected code path when bpp != 8:
that would be really nice! i struggled myself to get an account for phab.e
right. tga seems to support[0] 16bit with 5551 encoding, but there is currently no support in imlib for it at all, and 8 bit with 8 bit palette doesn't really make sense anyway. |
meanwhile i updated my patch to support palettized RLE-compressed pics too |
@rofl0r apropos formatting, is https://github.com/sabotage-linux/sabotage/blob/c4f1fe5307dd21bd53d17c51f32049092d6c9d34/KEEP/imlib2-tga-palette.patch#L73 this correctly formatted? I genuinely do not know the rules about that particular style enough to say. Submitted and waiting for review. |
me neither :) looks like we'll have to wait for complaints... thanks! |
patch against latest git is available here https://0x0.st/zEzS.patch |
@Ferada would you please mention to kwo on the bugtracker that i fulfilled his request with the above patch ? or maybe you just send him here so i can interact with him directly. |
Yes, updated. I ran |
@rofl0r was merged, please go ahead and verify this works for you then. Edit: Works for me FWIW. |
thanks for your help! it works as expected, also with RLE compressed variant (e.g.: https://0x0.st/z6ZY.tga ) |
Summary: implemented 8 bit color mapped images with 24/32bpp palette. This is coming from an issue on [[ derf/feh#491 | feh ]] to support indexed TGA images. Written by [[ https://github.com/rofl0r | rofl0r ]], I'm forwarding it because I already have the tools for submission set up. N.b. I'm not terribly familiar with the particular code style, if there's anything to format differently I'm happy to update. Test Plan: - Compared [[ https://0x0.st/zgB4.tga | example file ]] with known good in GIMP, looks okay. - Tested that said example file doesn't load without this patch (in feh, which uses Imlib2). Reviewers: kwo Differential Revision: https://phab.enlightenment.org/D10618
here's an example file https://0x0.st/zgB4.tga
it seems handling of TGA_TYPE_MAPPED is entirely missing in imlib2
The text was updated successfully, but these errors were encountered: