Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.mk: Use prefix in ICON_PREFIX #337

Closed
wants to merge 1 commit into from
Closed

config.mk: Use prefix in ICON_PREFIX #337

wants to merge 1 commit into from

Conversation

avindra
Copy link

@avindra avindra commented Oct 8, 2017

The PREFIX, if specified, should also be used to determine the ICON_PREFIX

This was originally written by @mimi1vx who I've tagged here.

The `PREFIX`, if specified, should also be used to determine the `ICON_PREFIX`
@derf
Copy link
Owner

derf commented Oct 16, 2017

PREFIX is deliberately ignored in this case.

make install app=1 (the only case in which this branch is relevant) is meant for end users installing feh via the Makefile on their system, so PREFIX is /usr/local in most cases. However, icons in /usr/local/share/icons are not generally supported, so even though feh itself ends up in /usr/local, its icons must be installed into /usr/share/icons.

So it may look like an omission, but is intentional. Thanks for taking the time to submit a fix, though :)

@derf derf closed this Oct 16, 2017
@avindra avindra deleted the patch-1 branch October 28, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants