Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mime-type 'audio/mpeg' for reading cover artwork #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eworm-de
Copy link
Contributor

This is required to support cover artwork from mpeg audio (mp3) files.

@derf
Copy link
Owner

derf commented Apr 27, 2022

Good point. Could you switch to strncmp so that it is consistent with the image/ check?

@eworm-de
Copy link
Contributor Author

It is consistent with checks for compression. 😉
The reason that the check for "image/" uses strncmp is that it handles a substring.

@avlec
Copy link
Contributor

avlec commented Apr 30, 2022

Both the linked issues in the function description have been marked as closed, is there any other reason to keep this workaround?

This is required to support cover artwork from mpeg audio (mp3) files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants