(GCP) Default Application Credentials flow/support (rebased and make tests pass) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR, I will try to take a look soon! Please feel free to remind me if I forget about it, my days are quite busy at the moment :) |
ingwinlu
force-pushed
the
gcp_instance_metadata
branch
from
2bf3c97
to
c779306
Compare
|
@dermesser thanks I will, can you maybe approve the github action again? |
glyn
reviewed
Nov 26, 2021
braincow
approved these changes
Nov 26, 2021
|
Apologies for the delay! The action is running again. |
ingwinlu
force-pushed
the
gcp_instance_metadata
branch
from
0f8389d
to
39c712d
Compare
|
I don't have anything more to add. |
|
As far as I can see, you've only extended the API. Therefore I propose to create a new minor release (as defined by semver) containing this code. Do you agree? |
|
No existing behaviour was touched, so a minor release seems to be way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests follows up on the work done by @braincow in #156.
It is rebased ontop of the current master, extends the structure to be inline with the new
with_clientfunctionality and fixes the test that was failing by allowing to provide a custom metadata url to the test server.Please keep in mind this is my first rust based pull request and I am happy for feedback.
There are still 2 TODO's in the diff which I kind of find improvable.