Make crypto provider configurable, rename feature and make hyper-tls feature visible #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threema-donat
force-pushed
the
feature-improvements
branch
from
f69fb61
to
a0e337d
Compare
serprex
reviewed
Jun 17, 2024
threema-donat
force-pushed
the
feature-improvements
branch
3 times, most recently
from
2561770
to
e032917
Compare
threema-donat
force-pushed
the
feature-improvements
branch
from
e032917
to
92fbdff
Compare
|
@dermesser tested with the four feature combinations
The test with the file seems to be flaky, could you please rerun this test? It would be awesome to have a release with this change, so that we could start using the version with hyper v1. |
serprex
approved these changes
Jun 18, 2024
threema-donat
force-pushed
the
feature-improvements
branch
2 times, most recently
from
14fffcd
to
010f7d0
Compare
dermesser
reviewed
Jun 26, 2024
|
Thank you for taking the time to clean this up, it's much needed! I will merge and release soon, I just left a minor comment on the tests. |
threema-donat
force-pushed
the
feature-improvements
branch
from
010f7d0
to
4a8ccfd
Compare
threema-donat
force-pushed
the
feature-improvements
branch
from
4a8ccfd
to
310ea83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.