Merge remote-tracking branch 'origin/3.4.x' into 4.0.x

derrabus · May 24, 2022 · 168939a · 168939a
2 parents 2c1fae8 + 7b85b8c
commit 168939a
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 8 deletions.
diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php
@@ -2192,17 +2192,9 @@ public function supportsReleaseSavepoints(): bool
 
     /**
      * Whether the platform supports foreign key constraints.
-     *
-     * @deprecated All platforms should support foreign key constraints.
      */
     public function supportsForeignKeyConstraints(): bool
     {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pulls/5409',
-            'AbstractPlatform::supportsForeignKeyConstraints() is deprecated.'
-        );
-
         return true;
     }
 

diff --git a/src/Platforms/SqlitePlatform.php b/src/Platforms/SqlitePlatform.php
@@ -580,6 +580,11 @@ public function getTemporaryTableName(string $tableName): string
         return $tableName;
     }
 
+    public function supportsForeignKeyConstraints(): bool
+    {
+        return false;
+    }
+
     public function getCreatePrimaryKeySQL(Index $index, string $table): string
     {
         throw new Exception('Sqlite platform does not support alter primary key.');

diff --git a/tests/Functional/Schema/SchemaManagerFunctionalTestCase.php b/tests/Functional/Schema/SchemaManagerFunctionalTestCase.php
@@ -445,6 +445,10 @@ public function testDropAndCreateUniqueConstraint(): void
 
     public function testCreateTableWithForeignKeys(): void
     {
+        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('Platform does not support foreign keys.');
+        }
+
         $tableB = $this->getTestTable('test_foreign');
 
         $this->dropAndCreateTable($tableB);
@@ -621,6 +625,10 @@ public function testAlterTableScenario(): void
         // dont check for index size here, some platforms automatically add indexes for foreign keys.
         self::assertFalse($table->hasIndex('bar_idx'));
 
+        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+            return;
+        }
+
         $fks = $table->getForeignKeys();
         self::assertCount(1, $fks);
         $foreignKey = array_shift($fks);
@@ -714,6 +722,12 @@ public function testAutoincrementDetectionMulticolumns(): void
 
     public function testUpdateSchemaWithForeignKeyRenaming(): void
     {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if (! $platform->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('This test is only supported on platforms that have foreign keys.');
+        }
+
         $table = new Table('test_fk_base');
         $table->addColumn('id', 'integer');
         $table->setPrimaryKey(['id']);
@@ -759,6 +773,12 @@ public function testUpdateSchemaWithForeignKeyRenaming(): void
 
     public function testRenameIndexUsedInForeignKeyConstraint(): void
     {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if (! $platform->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('This test is only supported on platforms that have foreign keys.');
+        }
+
         $primaryTable = new Table('test_rename_index_primary');
         $primaryTable->addColumn('id', 'integer');
         $primaryTable->setPrimaryKey(['id']);
@@ -1237,6 +1257,10 @@ public function testCommentInTable(): void
 
     public function testCreatedCompositeForeignKeyOrderIsCorrectAfterCreation(): void
     {
+        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('Platform does not support foreign keys.');
+        }
+
         $foreignKey     = 'fk_test_order';
         $localTable     = 'test_table_foreign';
         $foreignTable   = 'test_table_local';