Fixes to order that styles are applied in order to prevent loss of scroll position #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes the annoying "back button issue" in Safari (latest). |
|
v3 was just released. Since all the code is refactored, I don't believe this pull request can help. I'm going to close this issue. If you still experience this bug, please open up a separate issue. Thanks! 😋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems that I tried to fix.
_getBricks was going beyond its name and making all the bricks position absolute and bypassing the style queue. This meant that there was a brief moment where the container had a height of 0 and so there was a slight loss of scroll position when using the back button. The amount of loss depended on how far down the page you were and could get quite severe.
The style queue was setting the container height last. In the real world the style queue is processed so fast that it doesn't seem to make a difference what order it's done in but I think it is more sensible to set the container height first to prevent any loss of scroll position.
I didn't mean to kill your newline.