Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GetTeanats and IsPermittedPerTenant with descope tenants claim #439

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions descope/internal/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -821,13 +821,13 @@ func getAuthorizationClaimItems(token *descope.Token, tenant string, claim strin
}
} else {
var claimValue []interface{}
if token.Claims[claimDescopeCurrentTenant] == tenant && len(token.GetTenants()) == 0 {
if v, ok := token.GetTenantValue(tenant, claim).([]interface{}); ok {
asafshen marked this conversation as resolved.
Show resolved Hide resolved
claimValue = v
} else if token.Claims[descope.ClaimDescopeCurrentTenant] == tenant {
// The token may have the current tenant in the "dct" claim and without the "tenants" claim
if v, ok := token.Claims[claim].([]interface{}); ok {
claimValue = v
}
} else if v, ok := token.GetTenantValue(tenant, claim).([]interface{}); ok {
claimValue = v
}

for i := range claimValue {
Expand All @@ -846,7 +846,7 @@ func getAuthorizationClaimItems(token *descope.Token, tenant string, claim strin
}

func isAssociatedWithTenant(token *descope.Token, tenant string) bool {
return slices.Contains(token.GetTenants(), tenant) || (token.Claims != nil && token.Claims[claimDescopeCurrentTenant] == tenant)
return slices.Contains(token.GetTenants(), tenant) || (token.Claims != nil && token.Claims[descope.ClaimDescopeCurrentTenant] == tenant)
}

func getPendingRefFromResponse(httpResponse *api.HTTPResponse) (*descope.EnchantedLinkResponse, error) {
Expand Down
12 changes: 9 additions & 3 deletions descope/internal/auth/auth_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ var (
}
mockAuthorizationCurrentTenantToken = &descope.Token{
Claims: map[string]any{
claimPermissions: permissions,
claimRoles: roles,
claimDescopeCurrentTenant: "t1",
claimPermissions: permissions,
claimRoles: roles,
descope.ClaimDescopeCurrentTenant: "t1",
},
}
)
Expand Down Expand Up @@ -1045,6 +1045,12 @@ func TestValidatePermissions(t *testing.T) {
))
}

func TestGetTenants(t *testing.T) {
require.Equal(t, []string{}, mockAuthorizationToken.GetTenants())
require.Equal(t, []string{"t1"}, mockAuthorizationCurrentTenantToken.GetTenants())
require.ElementsMatch(t, []string{"kuku", "t1"}, mockAuthorizationTenantToken.GetTenants())
}

func TestGetMatchedPermissions(t *testing.T) {
a, err := newTestAuth(nil, DoOkWithBody(nil, ""))
require.NoError(t, err)
Expand Down
7 changes: 3 additions & 4 deletions descope/internal/auth/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,9 @@ func newExchangeAccessKeyBody(loginOptions *descope.AccessKeyLoginOptions) *exch
}

const (
claimAttributeName = "drn"
claimPermissions = "permissions"
claimRoles = "roles"
claimDescopeCurrentTenant = "dct"
claimAttributeName = "drn"
claimPermissions = "permissions"
claimRoles = "roles"
)

var (
Expand Down
7 changes: 7 additions & 0 deletions descope/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ type Token struct {

func (to *Token) GetTenants() []string {
tenants := to.getTenants()
if len(tenants) == 0 && to.Claims != nil && to.Claims[ClaimDescopeCurrentTenant] != nil {
return []string{to.Claims[ClaimDescopeCurrentTenant].(string)}
}
return maps.Keys(tenants)
}

Expand Down Expand Up @@ -218,6 +221,9 @@ func (to *Token) IsPermitted(permission string) bool {
func (to *Token) IsPermittedPerTenant(tenant string, permission string) bool {
permitted := false
tenants := to.getTenants()
if to.Claims[ClaimDescopeCurrentTenant] == tenant && len(tenants) == 0 {
return to.IsPermitted(permission)
}
tPermissions, ok := tenants[tenant]
if ok {
if tPermissionsMap, ok := tPermissions.(map[string]any); ok {
Expand Down Expand Up @@ -917,6 +923,7 @@ const (
ContextUserIDPropertyKey ContextKey = ContextUserIDProperty
ClaimAuthorizedTenants = "tenants"
ClaimAuthorizedGlobalPermissions = "permissions"
ClaimDescopeCurrentTenant = "dct"

EnvironmentVariableProjectID = "DESCOPE_PROJECT_ID"
EnvironmentVariablePublicKey = "DESCOPE_PUBLIC_KEY"
Expand Down
16 changes: 15 additions & 1 deletion descope/types_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func TestGetCreatedTime(t *testing.T) {
assert.True(t, r.GetCreatedTime().Equal(now))
}

func TestIsPermittedPerTenant(t *testing.T) {
func TestIsPermittedPerTenantFromTenantsClaim(t *testing.T) {
tenantID := "somestring"
dt := &Token{
Claims: map[string]any{
Expand All @@ -111,6 +111,20 @@ func TestIsPermittedPerTenant(t *testing.T) {
assert.False(t, p)
}

func TestIsPermittedPerTenantWithCurrentTenant(t *testing.T) {
tenantID := "t1"
dt := &Token{
Claims: map[string]any{
ClaimDescopeCurrentTenant: tenantID,
ClaimAuthorizedGlobalPermissions: []any{"a", "b", "c"},
},
}
p := dt.IsPermittedPerTenant(tenantID, "a")
assert.True(t, p)
p = dt.IsPermittedPerTenant(tenantID, "d")
assert.False(t, p)
}

func TestIsPermitted(t *testing.T) {
dt := &Token{
Claims: map[string]any{
Expand Down