Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The mentioned code must be in english #13

Closed
wzuqui opened this issue Apr 26, 2022 · 4 comments
Closed

The mentioned code must be in english #13

wzuqui opened this issue Apr 26, 2022 · 4 comments
Assignees
@brunobritodev
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wzuqui
Copy link

wzuqui commented Apr 26, 2022

dev-store/src/services/DevStore.Customers.API/Controllers/CustomerController.cs

Line 34 in 343c18c

public async Task<IActionResult> AdicionarEndereco(AddAddressCommand endereco)

@EduardoPires EduardoPires changed the title Não deveria ser em inglês? The mentioned code must be in english Apr 26, 2022
@EduardoPires
Copy link
Member

Yes. All code must be in English. Some pieces of code were forgotten during the translation.

@brunobritodev brunobritodev self-assigned this Apr 28, 2022
@brunobritodev brunobritodev added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
jmoldyvan added a commit to jmoldyvan/dev-store that referenced this issue May 10, 2022
@jmoldyvan
fix: translated function names and variable to english (desenvolvedor…
7ea1c7e 
…-io#13) & (desenvolvedor-io#16)
@jmoldyvan jmoldyvan mentioned this issue May 10, 2022
Merged
@jmoldyvan
Copy link
Contributor

i got to the issue here, but i did see there was quite a bit more code not in english? let me know if you want some more help with going through the code for translations

@EduardoPires
Copy link
Member

@jmoldyvan this was a project originally written in portuguese, but we decided to translate to english to be a global project. Some parts of code have been forgotten and need an english translation.

EduardoPires pushed a commit that referenced this issue May 11, 2022
@jmoldyvan
fix: translated function names and variable to english (#13) & (#16) (#…
8b40b11 
…17)
@EduardoPires
Copy link
Member

Fixed in #17

brunobritodev pushed a commit that referenced this issue Jun 6, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
676fbd9 
# [1.1.0](v1.0.0...v1.1.0) (2022-06-06)

### Bug Fixes

* removendo o dapper do repositório de produto ([e5fdc76](e5fdc76))
* removing smalltalk ([343c18c](343c18c))
* translated function names and variable to english ([#13](#13)) & ([#16](#16)) ([#17](#17)) ([8b40b11](8b40b11))

### Features

* Create CODE_OF_CONDUCT.md ([#18](#18)) ([d02a4ae](d02a4ae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobritodev brunobritodev

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EduardoPires @brunobritodev @wzuqui @jmoldyvan