Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be an english function name #16

Closed
thiaraujo opened this issue May 9, 2022 · 3 comments
Closed

Should be an english function name #16

thiaraujo opened this issue May 9, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thiaraujo
Copy link

dev-store/src/services/DevStore.Customers.API/Data/CustomerContext.cs

Line 55 in 44eed28

public static async Task PublicarEventos<T>(this IMediator mediator, T ctx) where T : DbContext

@brunobritodev brunobritodev added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
@jmoldyvan
Copy link
Contributor

just switching that to an english name? I got it

@jmoldyvan
Copy link
Contributor

is that the only instance of the function name? or do i need to search through other files to translate?

jmoldyvan added a commit to jmoldyvan/dev-store that referenced this issue May 10, 2022
@jmoldyvan
fix: translated function names and variable to english (desenvolvedor…
7ea1c7e 
…-io#13) & (desenvolvedor-io#16)
@jmoldyvan jmoldyvan mentioned this issue May 10, 2022
Merged
EduardoPires pushed a commit that referenced this issue May 11, 2022
@jmoldyvan
fix: translated function names and variable to english (#13) & (#16) (#…
8b40b11 
…17)
@EduardoPires
Copy link
Member

Fixed in #17

brunobritodev pushed a commit that referenced this issue Jun 6, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
676fbd9 
# [1.1.0](v1.0.0...v1.1.0) (2022-06-06)

### Bug Fixes

* removendo o dapper do repositório de produto ([e5fdc76](e5fdc76))
* removing smalltalk ([343c18c](343c18c))
* translated function names and variable to english ([#13](#13)) & ([#16](#16)) ([#17](#17)) ([8b40b11](8b40b11))

### Features

* Create CODE_OF_CONDUCT.md ([#18](#18)) ([d02a4ae](d02a4ae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EduardoPires @brunobritodev @thiaraujo @jmoldyvan