Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border type feedback #99

Open
c1rrus opened this issue Jan 13, 2022 · 4 comments
Open

Border type feedback #99

c1rrus opened this issue Jan 13, 2022 · 4 comments

Comments

@c1rrus
Copy link
Member

c1rrus commented Jan 13, 2022

Is the border composite type fit for purpose? Does it need more sub-values to account for features like outset, border images, multiple borders, etc. that some platforms an design tools have?

Please share your feedback, thoughts and ideas in this issue.

@c1rrus c1rrus added the dtcg-format All issues related to the format specification. label Jan 13, 2022
@c1rrus c1rrus changed the title Border type Border type feedback Jan 13, 2022
@kaelig kaelig added the Needs Feedback/Review Open for feedback from the community, and may require a review from editors. label Mar 8, 2022
@kevinmpowell kevinmpowell added this to the Next Draft Priority milestone Oct 3, 2022
@kevinmpowell kevinmpowell removed Needs Feedback/Review Open for feedback from the community, and may require a review from editors. dtcg-format All issues related to the format specification. labels Oct 3, 2022
@tlouisse
Copy link

Hi, what would be the recommended way to store border-radius?

@gossi
Copy link

gossi commented Feb 21, 2023

The more I use that, the more I think, "border" is the wrong word, instead "stroke" is more appropriate:

  • A ruler (<hr>) is a stroke
  • A border is a set of strokes (with position/alignment)

Or: A stroke can be a border, but a border cannot be a stroke.

And to add what @tlouisse said: A ruler (= a line) cannot have a radius.


So, there is:

  • stroke style: as already defined
  • stroke: style + color + width
  • border: stroke (+ location) 1
  • border-radius: targeting the border joints (in design tools, there is also joint variants)

1 When location is omitted, border is applied on all sides, then border equals stroke

@d01000100
Copy link

I don't know if this is the correct place to bring this up, but I've seen in a handful of designs (mostly documented in Figma) that some elements use "inside" or "outside" aligned borders, for example to create a focus "border" around a button.

I do know that it most technologies, this effect does not fall into the border property (For example in CSS you would set box-sizing: border-box) and some other technologies may not support it at all.

Is this "alignment" of the border being considered in any place on the standard?

@PavelLaptev
Copy link
Contributor

@gossi +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants