Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Settings / Digest Configuration #1249

Closed
cnvo opened this issue Mar 19, 2014 · 6 comments
Closed

Email Settings / Digest Configuration #1249

cnvo opened this issue Mar 19, 2014 · 6 comments
Assignees
Milestone

Comments

@cnvo
Copy link
Contributor

cnvo commented Mar 19, 2014

User should be able to receive topics via email in the following timeframes:

  • Daily
  • Weekly
  • Monthly

screen shot 2014-03-19 at 3 52 52 pm

I like the way it's displayed so far. I suppose we could show the following: category for each topic, number of posts in the topic, and the time at which the topic was created?

User should be able to select the following options (and you can add, modify, or remove any of this list, but I made this list from the top of my head), receiving an email:

  • each time you are thanked by another user
  • each time you are mentioned in a topic you favourited
  • each time someone posts a reply to a topic you've started

Since we have email digests already implemented, we can take this a bit further with this. Also, you should be able to opt-out of being send any emails other than important ones such as password reset, welcome email, etc. Some parts of the configuration should be via ACP, for example, to specify number of topics to show for both unread notifications and latest topics.

@cnvo cnvo changed the title Account Settings - Allow configuration of Email Settings Email Settings / Digests Configuration Mar 19, 2014
@cnvo cnvo changed the title Email Settings / Digests Configuration Email Settings / Digest Configuration Mar 19, 2014
@psychobunny
Copy link
Contributor

The "username made a new post" is also pretty ambiguous

Pretty good first iteration though :)

@julianlam
Copy link
Member

Thanks both 😄 I lagged on implementing this feature precisely because it causes so much extra maintenance work to also be added on to NodeBB.

Anyhow for the new post ambiguity, just need to modify the notification itself 👍

@julianlam
Copy link
Member

Using the "new & improved" templating engine, I should be able to add and remove different sections to the email easily. First thing on the docket is really just adding admin panel options and userland options so people can opt-out/in.

Currently, only users with unread notifications get the daily digest. I did this primarily so that while fire testing (testing on production, _woo!!_), we only send out a limited number at a time (46, for today's). Later, we can change that to sending to users who haven't visited in the past 24 hours, or even everybody.

Problem is you'd quickly run into the rate limiting if you tried sending an email to every user on our forum 😄

@cnvo
Copy link
Contributor Author

cnvo commented Mar 19, 2014

Sounds good guys! Can't wait for this to be implemented.

On Wed, Mar 19, 2014 at 7:17 PM, Julian Lam notifications@github.comwrote:

Using the "new & improved" templating engine, I should be able to add and
remove different sections to the email easily. First thing on the docket is
really just adding admin panel options and userland options so people can
opt-out/in.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1249#issuecomment-38119347
.

julianlam added a commit that referenced this issue Apr 16, 2014
@julianlam
Copy link
Member

The "send emails if you have unread notifs" is a bit naive, so I am changing it to emails are sent if you haven't been on the site for over 24 hours.

I'll also add an option to change email settings before this issue can be closed.

julianlam added a commit that referenced this issue Apr 16, 2014
julianlam added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue Apr 16, 2014
@julianlam
Copy link
Member

Should be in master now. Let me know if it's not working as intended.

Weekly and Monthly are greyed out at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants