Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to use the sounds system #1270

Closed
Schamper opened this issue Mar 25, 2014 · 5 comments
Closed

Allow plugins to use the sounds system #1270

Schamper opened this issue Mar 25, 2014 · 5 comments
Assignees
Milestone

Comments

@Schamper
Copy link
Contributor

Mentioned this earlier in a commit comment. Just wanted to put this here for the record, if that's alright ;)

@julianlam
Copy link
Member

Hey @Schamper -- just wondering what you'd like to achieve with this... I'm going to add in support so that plugins can add sounds to the system (and be selectable in ACP)... you can play sounds by requiring the client sound library:

require(['sounds'], function(s) {
  s.play('notification');
});

Edit: Whoops, closed by mistake.

@julianlam julianlam reopened this Mar 26, 2014
@Schamper
Copy link
Contributor Author

I'm going to add in support so that plugins can add sounds to the system (and be selectable in ACP)...

This basically. I'd image plugins would be able to define a sound name (like 'notification' in your snippet) and admins would be able to select the sound linked to that.

@julianlam
Copy link
Member

Closed via df8728c

@julianlam
Copy link
Member

@Schamper, take a look at nodebb-plugin-soundpack-default to see how I used the new hook.

New hook = not compatible until 0.4.2, of course, so keep that in mind 😄

@Schamper
Copy link
Contributor Author

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants